-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle STS Credentials region #8605
Conversation
Issues linked to changelog: |
Visit the preview URL for this PR (updated for commit 776da72): https://gloo-edge--pr8605-handle-sts-credentia-zwzo154e.web.app (expires Wed, 20 Sep 2023 19:10:25 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 77c2b86e287749579b7ff9cadb81e099042ef677 |
/kick failure in consul plugin tests, presumably a flake: https://storage.googleapis.com/solo-public-build-logs/logs.html?buildid=aaa1a4e9-cf13-457f-8478-17ec2c9dd0b1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
* update API * explicitly set region in serviceAccountCredentials * add changelog entry * relocate changelog entry to proper release * update test fixture in helm tests * Adding changelog file to new location * Deleting changelog file from old location * Adding changelog file to new location * Deleting changelog file from old location * add STS tests * Adding changelog file to new location * Deleting changelog file from old location * Adding changelog file to new location * Deleting changelog file from old location * Adding changelog file to new location * Deleting changelog file from old location * make region not required * add e2e tests against default region * correct typo in aws e2e tests * bump envoy-gloo version * remove unnecessary tests from AWS e2e test --------- Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> Co-authored-by: changelog-bot <changelog-bot>
* update API * explicitly set region in serviceAccountCredentials * add changelog entry * relocate changelog entry to proper release * update test fixture in helm tests * Adding changelog file to new location * Deleting changelog file from old location * Adding changelog file to new location * Deleting changelog file from old location * add STS tests * Adding changelog file to new location * Deleting changelog file from old location * Adding changelog file to new location * Deleting changelog file from old location * Adding changelog file to new location * Deleting changelog file from old location * make region not required * add e2e tests against default region * correct typo in aws e2e tests * bump envoy-gloo version * remove unnecessary tests from AWS e2e test --------- Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> Co-authored-by: changelog-bot <changelog-bot>
* update API * explicitly set region in serviceAccountCredentials * add changelog entry * relocate changelog entry to proper release * update test fixture in helm tests * Adding changelog file to new location * Deleting changelog file from old location * Adding changelog file to new location * Deleting changelog file from old location * add STS tests * Adding changelog file to new location * Deleting changelog file from old location * Adding changelog file to new location * Deleting changelog file from old location * Adding changelog file to new location * Deleting changelog file from old location * make region not required * add e2e tests against default region * correct typo in aws e2e tests * bump envoy-gloo version * remove unnecessary tests from AWS e2e test --------- Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> Co-authored-by: changelog-bot <changelog-bot>
# Regex copied from: https://github.com/solo-io/go-utils/blob/16d4d94e4e5f182ca8c10c5823df303087879dea/versionutils/version.go#L338 | ||
tag_regex := v[0-9]+[.][0-9]+[.][0-9]+(-[a-z]+)*(-[a-z]+[0-9]*)?$ | ||
tag_regex := ^v([0-9]{1,}\.){2}[0-9]{1,}$ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like you accidentally reverted this change from #8653
* Handle STS Credentials region (#8605) * update API * explicitly set region in serviceAccountCredentials * add changelog entry * relocate changelog entry to proper release * update test fixture in helm tests * Adding changelog file to new location * Deleting changelog file from old location * Adding changelog file to new location * Deleting changelog file from old location * add STS tests * Adding changelog file to new location * Deleting changelog file from old location * Adding changelog file to new location * Deleting changelog file from old location * Adding changelog file to new location * Deleting changelog file from old location * make region not required * add e2e tests against default region * correct typo in aws e2e tests * bump envoy-gloo version * remove unnecessary tests from AWS e2e test --------- Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> Co-authored-by: changelog-bot <changelog-bot> * codegen * codegen --------- Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com>
* update API * explicitly set region in serviceAccountCredentials * add changelog entry * relocate changelog entry to proper release * update test fixture in helm tests * Adding changelog file to new location * Deleting changelog file from old location * Adding changelog file to new location * Deleting changelog file from old location * add STS tests * Adding changelog file to new location * Deleting changelog file from old location * Adding changelog file to new location * Deleting changelog file from old location * Adding changelog file to new location * Deleting changelog file from old location * make region not required * add e2e tests against default region * correct typo in aws e2e tests * bump envoy-gloo version * remove unnecessary tests from AWS e2e test --------- Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com>
* Handle STS Credentials region (#8605) * update API * explicitly set region in serviceAccountCredentials * add changelog entry * relocate changelog entry to proper release * update test fixture in helm tests * Adding changelog file to new location * Deleting changelog file from old location * Adding changelog file to new location * Deleting changelog file from old location * add STS tests * Adding changelog file to new location * Deleting changelog file from old location * Adding changelog file to new location * Deleting changelog file from old location * Adding changelog file to new location * Deleting changelog file from old location * make region not required * add e2e tests against default region * correct typo in aws e2e tests * bump envoy-gloo version * remove unnecessary tests from AWS e2e test --------- Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> Co-authored-by: changelog-bot <changelog-bot> * trigger build * codegen --------- Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com>
Description